Corbin Robeck

Should add something like: set(CMAKE_CXX_STANDARD 14) set(CMAKE_CXX_STANDARD_REQUIRED ON) To the top level RAJA Perf CMake files?

Right. But I think what's happening is CMake is letting that get overridden by the compiler default. CMAKE_CXX_STANDARD_REQUIRED, I believe, should error out before getting there.

-std=c++14 is getting set: cd /RAJAPerf/build_cuda/src/basic && /cm/shared/apps/cuda11.2/toolkit/11.2.0/bin/nvcc -forward-unknown-to-host-compiler -ccbin=/opt/gcc/8.1.0/bin/c++ -DRUN_RAJA_SEQ -I/RAJAPerf/build_cuda/include -I/RAJAPerf/src/. -I/RAJAPerf/tpl/RAJA/include -I/RAJAPerf/build_cuda/tpl/RAJA/include -I/RAJAPerf/tpl/RAJA/tpl/camp/include -I/RAJAPerf/build_cuda/tpl/RAJA/tpl/camp/include -isystem=/cm/shared/apps/cuda11.2/toolkit/11.2.0/include -restrict -arch sm_70 --expt-extended-lambda --expt-relaxed-constexpr -O3 -DNDEBUG -Xcompiler=-fPIC -std=c++14 -x cu -c...

Isn't that this: https://github.com/LLNL/RAJAPerf/blob/develop/CMakeLists.txt#L116 @davidbeckingsale do you think we need REQUIRED here? set(CMAKE_CUDA_STANDARD_REQUIRED TRUE) set(CMAKE_CXX_STANDARD_REQUIRED TRUE)

> Also, about style. typically we want the commit title to be short oneliner and use the commit message body to provide more context and details. Right now the tile...

Yeah, I think that should be fairly straight forward. I guess we probably want a lit test to make sure the passes are actually still getting inserted into the pass...

> One suggestion is to simplify the test file. @Jokeren Thanks. I've added another, simpler, test file. I still think it's good to have a complex, realistic kernel, test file...

@antiagainst I think this should be good to go.

> Any way we could test this? I feel like we're super likely to break this the moment we refactor the function. @ptillet should be addressed now. Thanks!

@Jokeren please add your self to reviewers.