Corbin Robeck
Corbin Robeck
I need to add another test but you can merge for now and I can open another PR.
@Jokeren This should be OK to merge. From everything I can tell the graph test will just have one fewer kernels for Hip vs Cuda so I think the test...
The PR for getting this into Triton is here: https://github.com/triton-lang/triton/pull/3953 I would try adding a similar “Hello world” style test like in that commit to make sure everything is hooked...
@josemonsalve2 did you get this figured out?
> Overall this looks good, few concerns though: -What are the effects of compiling with shared library? -One effect I can think of is that both using shared library for...
> I would also like to understand the strategy with regards to the cache when we change the pass pipeline For the moment we just invalidate the cache whenever the...
@ThomasRaoux any more thoughts on this? Cache behavior should be sorted out now.
> > @ThomasRaoux any more thoughts on this? Cache behavior should be sorted out now. > > > > some more thoughts about caching, let me write down more details...
@ThomasRaoux were you able to look at this?
@ThomasRaoux I think I've addressed all review concerns. Took another pass and did not see anything glaring. No rush though if you want to take another period to review more.