CPerezz comments

Results 187 comments of


                                            CPerezz

Cargo should warn if "probably misnamed" config.toml is present.

I was working on this and I basically implemented the following changes [here](https://github.com/CPerezz/cargo/commit/cc71d3162ea195e0a15bce7faf7752adae378dee). But once done I realized this would collide with a lot of things. The user is free...

Add support for `Value::one()` and `Value::zero()` and maybe, `Value::<F::From>::from()`

I'll try to work on this and see if I can come up with something that reduces a bit the overhead. Thanks for the data @daira ! I was afraid...

Add support for `Value::one()` and `Value::zero()` and maybe, `Value::<F::From>::from()`

Extending the discussion in https://github.com/zcash/halo2/pull/699 about traitifying `Value` or any other ideas.

Add support for `Value::one()` and `Value::zero()` and maybe, `Value::<F::From>::from()`

Thanks for the elaborated reply @str4d . The transposing example is brilliant. And I did not think about it. Considering that this solves byte-conversion, we lack the `one`, `zero` and...

Add helper traits for constructing `Value::known` constants

Will continue the discussion of #698 here. Thanks @str4d for taking initiative on this. The issues are clear. And they obviously prevent us to go on the direction this PR...

Establish workflow for developing features in-situ

I think this is probably the best approach we can take. It will also be nice to doc this criteria in the repo so that it is very clear how...

Establish a mechanism or workflow for defining "code maintainers"

From PSE we have some experience with having reviewers from outside of the GH org and it requires permissions. Idk if you're ok giving them. So I'll explain what we...