CPerezz

Results 187 comments of CPerezz

I noticed Clippy will never pass here until #719 is addressed. Also, this should be ready for a final round of reviews @therealyingtong

The only things left unaddressed are: - Annotate Instance columns & display in `PermutationError` the annotations they have. - `Display` implementation would require to display the annotations for `Lookup`, `PermutationError`...

The last commits update this PR to: - Not use `&` and lifetimes across the annotation handling. - Not support custom `Display` impl with annotations for `VerifyFailure`. - Put the...

This review re-request button got crazy :sweat_smile: Apologies. @str4d @therealyingtong this should be ready to be shipped. I can put it under a nightly feature if you consider it.

I've extended it a bit. Now the `ConstraintNotSatisfied` case is also correctly handled as seen here: ``` Cell layout in region 'Wrong synthesis': | Offset |This is Advice!|This is Advice...

After 5e88f12 the render of Lookup table columns is enabled. Kudos to @ed255 for the help!!! This is the current output for the lookups where we show the column that...

After 08632e1a the format I achieved for the debug display of `VerifyFailure::ConstraintNotSatisfied` was as follows: ``` ConstraintCaseDebug { constraint: Constraint { gate: Gate { index: 0, name: "Equality check", },...

I think as said in #710 and in the last dev call, anyone is free to review code and it's much appreciated. The point is who is "obligated to review"...

I would like to take this if @ralfbiedert isn't working on it. Is that ok?