Sigbjørn Skjæret

Results 65 comments of Sigbjørn Skjæret

Sure, just fix the [EditorConfig](https://github.com/ggerganov/llama.cpp/actions/runs/10291422698/job/28483631617?pr=8917) failures first. :) But yeah, this one is also less likely to cause issues.

I guess unless there are any objections from @bartowski1182 or @danielhanchen we can merge this after the weekend?

> The only, minor, observation is that when converting an existing file to the new format, a `gguf_init_from_file_impl: invalid magic characters: '????', expected 'GGUF'` warning is displayed. Other than that,...

@compilade Time to merge this (and adapt #12718 afterwards)?

I noticed this char before, I always just assumed it was a spurious prompt print (since most templates end with `>`, but I see now that it's repeating the last...

> Hi Is the bug fixed? If not, Can I pick it up AFAIK no, please do.

You may want to check out an earlier attempt at ModernBert in #14014

Hey, sorry, this PR reminded me I had a lot of unsubmitted code locally, made #11909 that supercedes this...

Please be aware you may have better luck submitting this PR (with tests) to `llama.cpp` instead, see [CONTRIBUTING.md](https://github.com/ggml-org/ggml/blob/master/CONTRIBUTING.md).

> ```shell > $ cat > metadata.json { > "general.sampler.temp": 0.6 > } > EOF > ``` So, you're suggesting that parameters should be added manually before conversion? How likely...