Sigbjørn Skjæret

Results 71 comments of Sigbjørn Skjæret

@uncodecomplexsystems Patience, I'm sure there's just a lot going on (here or elsewhere) right now.

You can store the data in an UINT8 array, ~~if you need to store path too you can store it as an array of arrays, ie: [[path, data], [path, data]],...

Well, technically it can't because there's no (simple) way of passing variables. This variable in particular though should be replaced with the [strftime_now](https://huggingface.co/docs/transformers/v4.50.0/en/chat_templating_writing#callable-functions) function in the template. If that hasn't...

@ochafik WDYT, is this something that can/will be supported? AFAIK the only other use-cases for variables is RAG (`documents` variable) and IBM Granite's `thinking` and `controls`.

> Which granite model are you looking at, btw? ([ibm-granite/granite-3.1-8b-instruct](https://huggingface.co/ibm-granite/granite-3.1-8b-instruct) has no `thinking`, and its `controls` [doesn't seem very standard](https://huggingface.co/docs/transformers/main/en/chat_template_advanced)) The [ibm-granite/granite-3.2-8b-instruct](https://huggingface.co/ibm-granite/granite-3.2-8b-instruct) has these, there doesn't really need to be...

> Don't try to access the previous element of a regex seq if the vector is empty. Prevents segment violation failures for regexes like `^?[0-9]$` and `^(?:a|b)$`. The latter should...

@rick-github I think both examples should report errors instead of quietly eating the expression characters. The first example is a clearly invalid expression and should be reported as such, and...

I'm not talking about improving the parser, just reporting the error instead of quietly mangling the expression.

Just adding an error to the `_errors` stack and returning an empty pair might do the trick?