Sigbjørn Skjæret

@ikawrakow Interesting, apart from LLaMA-v2-7B it wasn't much of a difference though. However the difference in actual output with my imatrix on the gorilla model is night and day, from...

@ikawrakow I don't know if you've had time to look at this or not, but I've been trying to determine if my changes have any real-world adverse impact with various...

Good suggestion, however you are using the logging module wrong. You must at the very least create and use a named instance with logging.getLogger(), see the [documentation](https://docs.python.org/3/library/logging.html#logger-objects).

> The provided usage is not exactly wrong. You're not restricted from using library methods directly. While true it's a good idea not to, it will make things a lot...

Almost. :) You missed a couple of `logging` uses though, and you shouldn't use `__name__` as the logger name in a stand-alone script (it'll just be `__main__`), just calling it...

> > You missed a couple of `logging` uses though, [...] > You mean do_dump_model()? well in that case, its explicit a dump so I suppress all logging (unless --verbose...

> Ah dang. Yeah I see what you mean. Fixed thanks Great, but [this](https://github.com/ggerganov/llama.cpp/pull/6511/commits/6e0ae011a050b86b9f6a71ba3d0fab086a06f2ea#diff-db4ed1f953cd7f07c37dfe2d725ac7f8ccae3fbb822cebd01662682f77e6ffe7R1482) was probably not intended though. :)

Great work. :) A final note however, you should use `__name__` as logger name for everything in gguf-py/gguf as they will be imported and not run directly.

> So you are saying just specifically for `gguf-py/gguf` because it's used within other scripts? Yes, because `__name__` will contain the module path in this case (and thus all be...

@mofosyne Great work here, unfortunately I think you were a bit unlucky and fell right between some urgent events, leaving everyone very busy, which has postponed the merge of this...