CHr15F0x
CHr15F0x
I was thinking about an additional command line switch to just use default commit types without modifying `Cargo.toml`. The rationale for this would be: when collaborating on a bigger project...
This issue contains follow up tasks for #1704 - [x] #1856 - [x] #1858 - [ ] #1857
We should consider refactoring the internal representation to reflect the latest block header from p2p perspective, which means that at least `state_diff_commitment` and `state_diff_length` should be included in it. Consider...
- use a test version of peer_aware::Client to inject responses - test happy path and if particular failures map to proper error variants - use rstest to reduce boilerplate duplication...
sync_handlers proptests proved to be hard to maintain and understand. Execution times are also a big burden.
By default these tests are ignored, nevertheless they rely on goerli which leads to fails rn: ``` failures: v04::method::add_declare_transaction::tests::duplicate_transaction v04::method::add_declare_transaction::tests::duplicate_v3_transaction v04::method::add_declare_transaction::tests::insufficient_account_balance v04::method::add_declare_transaction::tests::insufficient_max_fee v04::method::add_deploy_account_transaction::tests::duplicate_transaction v04::method::add_deploy_account_transaction::tests::duplicate_v3_transaction v04::method::add_invoke_transaction::tests::duplicate_transaction v04::method::add_invoke_transaction::tests::duplicate_v3_transaction v06::method::add_declare_transaction::tests::duplicate_transaction v06::method::add_declare_transaction::tests::duplicate_v3_transaction v06::method::add_declare_transaction::tests::insufficient_account_balance v06::method::add_declare_transaction::tests::insufficient_max_fee...
Investigate the following, based on @Mirko-von-Leipzig [comment](https://github.com/eqlabs/pathfinder/pull/1838#discussion_r1514255815): > What do you think of having a separate stage just for state trie operations? As in, this stage just writes the state...
provided that Juno is on par with current spec implementation.
Currently: - iterates all peers, returns the first non-empty reply range, even if it is shorter than requested Should: - turn to other peers to fill the missing part of...