Alex Eremin
Alex Eremin
> @CAHEK7 I cannot add you as a reviewer for this PR 😅 So I have tagged to send a notification to you That's because I'm not a part of...
I'd like to ask how did you check that it's unusable?
It's probably a good place for all those functions. https://github.com/ROCm/MIOpen/blob/develop/src/include/miopen/mlo_internal.hpp
In any case, it goes to OS for no reasons - with all those string names, reparsing and stuff, while we have to update just one global variable.
@atamazov it will be generalized if the tests are using the same structure for the test cases or the structures are different, but compatible and can be printed via template...
Probably @apwojcik can provide some insights. At least he participated in windows CI stage setup.
> > Probably @apwojcik can provide some insights. At least he participated in windows CI stage setup. > > Why is not include in hip sdk if it is compiling...
Majority of tests heavily rely on `vector`
> @randyspauldingamd I believe this is now your PR 😄. Does it pass the CI? It doesn't. The tests, especially old ctests, heavily rely on that `int` and that's why...
> can we add a unit test for this? It's barely possible, at least without affecting the current development and CI, and at least the test should be added as...