Crystal Durham

Results 508 comments of Crystal Durham

For pest proper, having a debugger is a huge quality of life thing. For a from-pest conversion, though, I don't know whether a dedicated debugger is practical. If you're using...

Initial draft idea: ```rust #[derive(Debug, PrecClimb)] #[prec_climb(rule(Rule::expression))] pub enum Expression>, op::Choice, Box>, op::StrictSeq, Box>, op::TriviaSeq, Box), } ``` Potential knobs: - Partially re-implement [`pest::prec_climber::PrecClimber`](https://docs.rs/pest/2/pest/prec_climber/struct.PrecClimber.html) based on [`FromPest`](https://docs.rs/from-pest/0.3.1/from_pest/trait.FromPest.html) machinery instead of...

How would you bundle prefix and postfix operator handling into this? I understand how precedence climbing works for binary ops, but I'm unsure how it's extended to handle unary ops...

I think it's best to structure this in a way that it's expected that the user take the output and commit it to their repository to be maintained by hand...

This should already work manually, and is definitely what I'd consider the "canonical" translation that such a tool should generate. They're powered solely by provided implementations in from-pest: - [`impl>...

Generally, I think that a sensible default for atoms would be to store a `pest::Span`, or potentially a custom `From` (which could handle being an owning version instead of borrowing)....

Barring any further suggestions, I'm probably going to do a large refactoring of everything in the second half of December. That will set up for this change, though doesn't require...

For context, nom4's error structure: ```rust type IResult = Result; pub enum Err { Incomplete(Needed), Error(Context), Failure(Context), } pub enum Context { Code(I, ErrorKind), #[cfg(verbose_errors)] List(Vec), } ``` Translating into...

This is probably a bit more involved than I'd wish, as it adds state to the conversion where it didn't exist before. However, here's a rough outline of what needs...

@rustbot ready Finally got around to fixing the broken link and addressing the nits. Rebase was necessary to be able to check doc build locally.