Crystal Durham

Results 508 comments of Crystal Durham

> Would that be clearer as `ghp-upload` then? Yeah, probably, unless I can make it more generic to where it works with other service providers. > - What is gh-specific...

@epage Let me reiterate this: there is no coveralls specific code in this crate. All we do is tell kcov that the user requested the kcov coverage be uploaded to...

pinging @kennytm for cargo-kcov; we shouldn't ignore that work. On linking cargo versus calling: - https://doc.rust-lang.org/cargo/reference/external-tools.html (excerpts) > ## Information about build > > When passing `--message-format=json`, Cargo will output...

For ghp-upload, I've just got to gather the time to pull it out, which should happen this weekend. (And to make sure it practices the best-practices that we're going to...

And that's why I went and posted it to users.rust-lang.org :)

I can tell you what causes it: [the new lockfile format](https://blog.rust-lang.org/2020/01/30/Rust-1.41.0.html#less-conflict-prone-cargolock-format). I think cargo-travis "just" needs to update cargo-as-a-library and it should "just work" again. In the mean time, you...

- [x] serde support

When the stdlib implementation is swapped to be backed by parking_lot, then the serde implementation on the stdlib types will be sufficient. Whatever serde support is considered in-tree, make sure...

I believe the API is sound, but the implementation isn't. The `ManuallyDrop` needs to be created directly around the unerased pointer to avoid dropping it, and the `&mut` version needs...

NB: I also proposed giving `Visit` a lifetime as part of https://github.com/tokio-rs/tracing/pull/2048