Crystal Durham

Results 507 comments of Crystal Durham

cc list of potentially interested parties: - @Marwes, @brendanzab (`codespan`) - @wycats, @jonathandturner (`language-reporting`) - @zbraniecki (`annotate-snippets`) - @matklad (this started with me looking at trying `rowan`+`codespan`)

Big apologies: I forgot that I had an out-of-date example in the repository when I posted this; I didn't mean to mislead. I've dropped the builder API (if you look...

Just a few more notes: - I'm convinced now that LSP support should be out-of-tree. - To that effect, perhaps I/we could make a diagnostics library that supports LSP that...

@kevinmehall yes, the intent was that it would be possible to implement `Span` for types that map multiple files into one dimensional space. I overlooked that resolution to the origin...

Let me drop this here while it's fresh on my mind, though I should admit it's unbaked while I need to run off to bed again. Here's the input structure...

@wycats I'm not on any team right now, I just chose this as a pet project for October (as I'm working on a [blog post series](https://dev.to/cad97/crafting-ide-ready-compilers-500o) that would benefit from...

@zbraniecki my impl uses a lot of `dyn Trait` even internally whereas you're using `impl Trait` in a lot of the same places; for comparison's sake, could you do a...

OK, I decided not to update the OP but just to do the comparison here. I've attempted to normalize some naming and removed export locations for the purposes of comparison,...

I've made a PR with an implementation of my new proposed API, and honestly, if we acquiesce support for non-ANSI coloring, I think it's the best yet. It even supports...

For clarity, since most of the code moved around and was adjusted: API design is by me, implementation code is directly adapted from the `cleanup` branch. I'd still suggest expanding...