Results 1797 comments of Sebastian Thiel

Thanks a lot for your help! ###### Thoughts It looks like the question here is of `UnexpectedEOF` could also be another kind of error which would indicate more clearly that...

Thanks for bringing up ideas for a way forward to reducing compile times, it's very much appreciated and I think it's good to start this sooner than later. ##### Monomorphization...

> Once `Progress` is changed to use immutable reference, perhaps we can change this to return `AtomicUsize` instead? It already does it, but it's using shared ownership. Doing so actually...

I thought about monomorphization a little more and after consulting with @joshtriplett (thank you 🙏) came to a conclusion that I find exciting enough to share. First of all, what...

That's a good idea! It would check what is name is and then act differently depending on that. I think from a setup and installation perspective, it's easiest to declare...

I spiked it and think that doing so only benefits installation *if* links are used, overall compile time should then be lower, as well as the overall size on disk....

> I will open a separate PR to de-`momo` functions using `TryInto` since there are only a few of them and they might use `.map_err`, which is really hard to...

> I think we should do the benchmark on GHA since this is the main blocking when creating and updating a PR, especially Windows and MacOS, which are much slower...

I apologize for having been so negative - this was an expression of my disappointment, having expected massive wins but getting only marginal ones. Having thought about this more, it's...

> 👍 though FnOnce is indeed a hard problem that needs rustc to support "move-by-ref" and better Unsize support. You obviously know a lot about these things, and maybe there...