Results 1797 comments of Sebastian Thiel

Thanks a lot for bringing this up, and for all the detective-work that went into this incredibly thorough analysis! From todays point of view, I think trying to kill child...

Thanks so much for the clarification! Indeed, I believe I was confused by process groups which naturally do the right thing. And even if that wouldn't happen, sub-processes would naturally...

> --but what I did read of it reminded me that registering signal handlers in a library may need to be opt-in, since it could interfere with some ways of...

Thanks so much for sharing your insights on signals and shells. As always, way ahead of me :)! > If I think of something for this, maybe I'll open a...

Could you provide an example that is reproducible by executing a python script? `as_process` is false by default and doesn't need to be passed in order to allow for `kill_after_timeout`...

Thanks a lot for the additional description. However, it's not what could move this issue forward as there is no way to reproduce it. Thus I am closing it but...

Thanks for the script, appreciated. For completeness, which OS/platform are you testing on and which GitPython version are you using (along with the python interpreter version)? Thanks again.

Thanks for bringing this to my attention - I definitely wasn't aware. Generally, if the user obtains a running process, then they are responsible for handling it no auto-killing should...

> Whether or not `output_stream` continues to suppress `kill_after_timeout`, perhaps it should be made more explicit in the `Git.execute` docstring that `output_stream` is blocking. > > I think this doesn't...

> I'm not sure, but it does look like that could be a problem. I suspect that may not be natural o fix together with the above stuff, though. It...