Results 518 comments of Sebastian Thiel

I have created a draft of [simple renames](https://github.com/Byron/cargo/blob/fe11e100eac073f62f6cae51b777f4d5a6e1e2f3/tests/testsuite/metadata.rs#L4100-L4124) in resolve metadata, which result in some _ambiguity_ in the `deps.name` field as it now possibly corresponds to multiple names which are...

@ehuss I believe the RFC is implemented from all I can see and has a few tests to support that. Maybe that qualifies it for a first review round. What...

Now that the PR for RFC-3028 has been merged (🎉) I am in the process of readying this one for review. When rebasing against master, the `filter-madness` that was generously...

After trying to address the left overs from RFC-3028 I have arrived in a state where I'd need input to learn how to proceed from here. Besides the [question around...

Thanks @joshtriplett for sharing, for a moment I thought I knew how to proceed but then the moment vanished, and here is why 😅. I think the following parts are...

> Perhaps this deduplication is happening as part of unification, and since you're not supporting unification, you're getting duplicates in the dependency graph? You might try a test with a...

Alright, I think I am onto something here and should be able to eventually get to the bottom of this. The recent failure on windows is indeed because… - units...

Just to follow up on the previous question about deduplication and in short: the existing deduplication mechanism works exactly as it should. Issues occur due to uplifting when there is...

Thanks, this helped me to fix the same issue by settings `runs-on: windows-2019` for the time being.

Now that `gitoxide` is thinking about stability as well it became clear that without a 1.0 `bstr` release this couldn't ever happen. I am glad to see this is actively...