Sebastian Thiel comments

Results 1780 comments of


                                            Sebastian Thiel

Improvement: Full plan for the new Integrate Upstream button and request for deletion of local and remote branches

Thanks so much for the analysis, and for cross-linking the related issues! I agree with the sentiment that there should be a choice on how to integrate. Personally I think...

Remove 'log' command and related code

To see more easily what's affected, you can run `cargo check --all-targets`.

Branch list view allows to apply a branch to the workspace that is applied already

Maybe you have an idea if this is a feature or not @estib-vega .

Encoding issue with tags in packed-refs file

Thanks for reporting! GitPython absolutely has a problem with encodings, in that it *should* use bytes in most places where it now uses strings, and the same is true for...

fix(git): Basic Reftable compatibility and future-proofing

Please note that this is best reviewed with "Hide whitespace" enabled.

fix(git): Basic Reftable compatibility and future-proofing

Thanks a lot for the review! I am still working on the `git-metrics` tests of which 4 regress when using Git, but I will see if this is something with...

fix(git): Basic Reftable compatibility and future-proofing

Thanks for the approval, I hoe to get CI green tomorrow.

fix(git): Basic Reftable compatibility and future-proofing

This should go through now. Please note that while considering to fix the "staged changes don't show with Git" issue, I noticed that this would require another call via `git...

persistence of unassigned changes that survives application restarts

CC @estib-vega .

The slotmap turned out to be too small

Thanks for reporting! This shouldn't be happening as it starts out the slotmap with `num_files_to_open * 2`, so there is always twice as much as it would need to map...