dd-trace-js
dd-trace-js copied to clipboard
remove shimmer.unwrap and shimmer.massUnwrap
We weren't using them outside a few use cases:
- In appsec, where it was used as enabled/disabled state, and that's now been replaced with a variable.
- In OpenAI, where it was added out of fear of the map in shimmer holding on to objects. That map gets removed by this commit anyway.
Meanwhile, unwrap added an extra unnecessary stack frame to every function call when using wrapFunction.
Overall package size
Self size: 8.25 MB Deduped: 94.54 MB No deduping: 95.05 MB
Dependency sizes
| name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.2.2 | 29.27 MB | 29.27 MB | | @datadog/native-appsec | 8.3.0 | 19.37 MB | 19.38 MB | | @datadog/native-iast-taint-tracking | 3.2.0 | 13.9 MB | 13.91 MB | | @datadog/pprof | 5.4.1 | 9.76 MB | 10.13 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.6.0 | 2.58 MB | 2.72 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.0.1 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe
Benchmarks
Benchmark execution time: 2024-12-12 20:36:03
Comparing candidate commit d5dfdb448ef66b2c486d23aec4d42796ccead210 in PR branch bengl/remove-unwrap with baseline commit 43046841de989cdb98b475ea4dc7ef02c3736484 in branch master.
Found 2 performance improvements and 0 performance regressions! Performance is the same for 259 metrics, 5 unstable metrics.
scenario:plugin-graphql-with-depth-off-18
- 🟩
max_rss_usage[-84.055MB; -82.453MB] or [-8.997%; -8.825%]
scenario:plugin-graphql-with-depth-on-max-18
- 🟩
max_rss_usage[-88.762MB; -71.086MB] or [-9.415%; -7.540%]
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 87.46%. Comparing base (
4304684) to head (d5dfdb4). Report is 410 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #4610 +/- ##
===========================================
+ Coverage 0 87.46% +87.46%
===========================================
Files 0 14 +14
Lines 0 702 +702
===========================================
+ Hits 0 614 +614
- Misses 0 88 +88
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
Closing due to already being removed