Mathijs van Veluw
Mathijs van Veluw
I marked it as Draft to first add the missing functionality to Vaultwarden.
Once the following PR is merged: https://github.com/dani-garcia/vaultwarden/pull/2698 This PR will work without issues.
You need to run `npm ci` in the main directory. Once that is done you need to go to the apps/web folder, and run the build command. Check the Dockerfile...
> > @bitwarden/[email protected] dist:oss:selfhost > > npm run build:oss:selfhost:prod > > > @bitwarden/[email protected] build:oss:selfhost:prod > > cross-env ENV=selfhosted NODE_ENV=production npm run build:oss > > sh: 1: cross-env: not found Not...
Ah, in that case, since you change stuff, then i think you need to use `npm install`. And if that works, the i would use that. For other how-to's i...
@MFijak Thanks for the contribution. I have quickly scanned the PR and added some remarks. There may be more items i need to check. But this is a nice start...
> I am glad to hear that! No worries take your time. > > Just a small question. You wrote that you added some remarks. Are these visible to me?...
First, sorry for not checking this earlier. I did some quick checking. And i probably missed some important stuff to nag about 😉 Overall i think it looks nice. There...
> Ah this the only thing left to make sure my mom can use it without her forgetting her password. Just curious how far are you? This will not prevent...
> > Just curious how far are you? > > This branch is already functional in the backend, you can login with SSO already. What is missing is fixing the...