Mathijs van Veluw

@dlehammer, is there a reason you have this marked as a WIP/Draft PR?

> so I doubt it would appeal to many users. That doesn't mean we shouldn't add this attribute. And, if I'm correct, I thought that MS Edge has that feature...

> > 2. I added your mentioned web-socket logout within my latest commit. > Seems to me like the default behavior of at least web-vault That is true for the...

Did some further testing and seems to work fine. I only wonder if we do not want to have this custom resolver as a default for everything. It can also...

> I just had a brief look at the PR so maybe I missed it but is it possible to disable this feature in the configuration? I am already using...

I do not have much time actually. Also, I'm a bit puzzled with all the different SSO PR's. And I am a bit hesitant to merge one if that for...

> Why not finally add at least one way to support OIDC? You can also flag it as preview feature or something like this to get feedback from the community,...

> @BlackDex Hey [fixed](https://github.com/dani-garcia/vaultwarden/pull/3899/commits/9ce3d5f699c5d2673d7a77d52309f890c5415751) an issue with the upgrade to [jsonwebtoken=9.0.0](https://github.com/dani-garcia/vaultwarden/blob/ecb31c85d68202f9d215c8ce12939158fb858af9/Cargo.lock#L1551): > > * [Reject tokens when claims has an aud, none expected Keats/jsonwebtoken#332](https://github.com/Keats/jsonwebtoken/pull/332) make the audience mandatory > >...

My first question would be, why change `Host` to `Domain`? That is not how the header is called. And a dev tip, install and activate `pre-commit`, that will help fixing...

It definitely isn't a domain, a domain is the last 2 (or 3) parts. So, a domain is `vaultwarden.org`, a host is `vault.vaultwarden.org`, so what we are receiving is actually...