Hugo Gruson

Results 344 comments of Hugo Gruson

Thinking about this again: > Would it be possible to let users add a custom extra value to include in the key for example? `cache-version` is basically this. So I...

I think it makes more sense to step down as principal maintainer in favour of someone closer to the field. I'm happy to remain involved as a co-maintainer focusing on...

I'm not so much thinking about printing at the moment. As you say, I'm happy for users to rely on their own favourite package for this. But `read/write_zattrs()` have a...

Good to know we agree on the way forward then! I don't think super strongly on the naming issue. I think I mostly got confused because I thought you were...

The benefit of the first solution is that you can (cleanly) create a forecast of a given type programmatically. ```r type

> I think so. My rationale would be that you want to be able to check whether something is a forecast object and also whether it is a forecast object...

> I'm assuming @seabbs response would be that you could always call the specific method (e.g. is_forecast.forecast_binary) explicitly. No, this is different. `is_forecast.forecast_binary()` will tell you if an object is...

Flagging as related: https://github.com/r-lib/lintr/issues/2703

Related discussion in the comments of https://github.com/r-lib/lintr/issues/2742

I would go a bit further and then that `undesirable_function_linter()` should be restricted to function calls. If we only ignore assignments and I define a `foo` variable as you did,...