Hugo Gruson

Results 344 comments of Hugo Gruson

I opened a related issue in air (https://github.com/posit-dev/air/issues/398) and Lionel (not tagging to avoid spam but we could invite him to this conversation) pointed our the related portion of code...

Now, whether this has any measurable impact is another good question 🤔

Something that could maybe help is linking to linters that will reduce the cyclomatic complexity, such as `unnecessary_nesting_linter()`, and maybe also `repeat_linter()`, `stopifnot_all_linter()`, etc.

I'd be wary of conflicts if they affected new contributors but it seems almost all currently open PRs come from lintr authors, or previous contributors. Speaking from myself, I'd be...

Probably at the beginning at least, it's safer to restrict this to string literals on the left-hand side to allow the specific case when people want to test for the...

Yes, I noticed the incorrect `"pkg" %in% installed.packages()` in some examples. But by this I also meant linting `"pkg" %in% installed.packages()[, 1]` and `"pkg" %in% installed.packages()[, "Package"]` which are frequent...

@csoneson, could you please also set an editorialbot reminder for me? It looks like I can't do it myself as a reviewer. ``` @editorialbot remind @Bisaloo in four weeks ```

## Review checklist for @Bisaloo ### Conflict of interest - [x] I confirm that I have read the [JOSS conflict of interest (COI) policy](https://github.com/openjournals/joss/blob/main/COI.md) and that: I have no COIs...

As an additional general comment which doesn't fit well in an issue: I believe this package is useful since contact data is absolutely fundamental in many epidemiological models, but we...

The issue is that we pass a buffer of size `NULL` here: https://github.com/Huber-group-EMBL/rhdf5/blob/919a739fe5cc4e1b8e862c15d75a5b636975f3fc/R/H5P_extras.R#L86 Would it make sense at all for your use case to use a simpler array with fixed-length...