Benjamin Van Ryseghem

I'm in the process of reviewing this code. There are several points I would like to address, and I'm still thinking about how to do it: - I'm not very...

> This branch cannot be rebased due to conflicts The first step would be to make it mergeable :smile:

thanks!

@all-contributors please add @lexanth for bug

Thanks for the fix :smile: Could you please: - add a test (in the same commit) - add a line in the CHANGELOG (in the same commit) - add yourself...

Thanks! Could you please merge your 2 first commits so that the code and the tests goes in the same? Thanks a lot!!

You should only have 2 commits here: - one with the code, the test and the Changelog - one with the author Could you please rebase and rewrite to achieve...

@Kanna727 Could you please: 1. clean the git history so that the "merge" (should have been a rebase) doesn't appear 2. follow the other git commit convention for the git...

You load the languages, but numbro do not register them automatically (so that tree-shaking algorithm can work). just add first ```js Object.values(numbro.allLanguages).forEach(function(data) { numbro.registerLanguage(data); }) ``` And it works :smile:

You are right! Feel free to open a PR to add the documentation :smile: