Percentages with parentheses for negatives are incorrect

Open lexanth opened this issue 5 years ago • 4 comments

numbro(-0.5).format({output: 'percent', negative: 'parenthesis'})

Expected: (50%)

Actual: (50)%

I suspect parenthesis for negative is the last thing that should be applied?

Oct 30 '20 09:10 lexanth

Similar issue for currency - the currency should be inside the parentheses, rather than outside

Oct 30 '20 09:10 lexanth

thanks!

Oct 30 '20 10:10 BenjaminVanRyseghem

@all-contributors please add @lexanth for bug

Oct 30 '20 10:10 BenjaminVanRyseghem

@BenjaminVanRyseghem

I've put up a pull request to add @lexanth! :tada:

Oct 30 '20 10:10 allcontributors[bot]