fixes #618

[Kanna727]

unformat("$") will return undefined as is the case for unformat("")

[Kanna727]

This PR fixes #618

[BenjaminVanRyseghem]

Thanks for the fix :smile:

Could you please:

• add a test (in the same commit)
• add a line in the CHANGELOG (in the same commit)
• add yourself to the AUTHORS list (in another commit)

Thanks again!!

[Kanna727]

Done

[BenjaminVanRyseghem]

Thanks! Could you please merge your 2 first commits so that the code and the tests goes in the same?

Thanks a lot!!

[Kanna727]

Thanks! Could you please merge your 2 first commits so that the code and the tests goes in the same?

Thanks a lot!!

Done

[BenjaminVanRyseghem]

You should only have 2 commits here:

• one with the code, the test and the Changelog
• one with the author

Could you please rebase and rewrite to achieve this please :smile:

[Kanna727]

I hope it's all good now

[Kanna727]

@BenjaminVanRyseghem Please review and approve this PR. I've rebased it to only 2 commits.

[Kanna727]

@BenjaminVanRyseghem Any updates?

[Kanna727]

@BenjaminVanRyseghem Please let me know if I've to do any more changes. I've a dependency on your package

[BenjaminVanRyseghem]

@Kanna727 Could you please:

1. clean the git history so that the "merge" (should have been a rebase) doesn't appear
2. follow the other git commit convention for the git messages (short description starting with an uppercase etc)

I'm sorry that you're holding on this, but until very recently, the build where not ok, and the branch out-dated