Benjamin Rodenberg

Results 143 issues of Benjamin Rodenberg

Ported case from `tutorials/cylinder-flap-3d/OpenFOAM-FEniCS/Solid/` @ 0d51b33aa276d5d65a67281187cdea6b25e68cb4 to preCICE v3. ### Important differences to existing cases (possible todo) : * `solid-fenics` uses `Forces`, not `Stresses` * `solid-fenics` uses a linear solver,...

There seems to be a regression in `perpendicular-flap/solid-fenics` when looking at the tip displacement: ![image](https://github.com/user-attachments/assets/887449fc-c881-4c8f-badd-f70ed48116ed) https://github.com/precice/tutorials/pull/554 is a candidate. Maybe the issue is related to checkpointing and how the values...

bug

See https://github.com/precice/precice.github.io/pull/414 for the motivation for this bugfix release. I'm creating this branch and PR to start collecting relevant changes. Note that it is still unclear if and how we...

maintainability
compatibility

@fsimonis proposed creating packages for the python-based solvers. See https://github.com/precice/tutorials/issues/547#issuecomment-2333343306. I would suggest to do this as a follow-up step when https://github.com/precice/tutorials/pull/563 is complete.

Originally contributed by @khalilhkiri and factored out from https://github.com/precice/fluent-adapter/pull/32. Updates the adapter to preCICE v3.

compatibility

The FEniCS adapter performs its own interpolation [here](https://github.com/precice/fenics-adapter/blob/394664dd720bd8d4e5a5f50aa7cdb1e5c7af1e95/fenicsprecice/expression_core.py#L172). With the new just-in-time mapping feature (https://github.com/precice/precice/pull/2099) we could remove this interpolation and directly use the interpolation in preCICE.

enhancement
student
maintainability

The API function `initialize` only accepts a `coupling_subdomain`: https://github.com/precice/fenics-adapter/blob/a64f1d6905790148f462ef0272ff771b5ad4b15d/fenicsprecice/fenicsprecice.py#L267 A `coupling_subdomain` has to be defined symbolically by inheriting from the `fenics.SubDomain` (see [here](https://github.com/precice/tutorials/blob/7314ad40d636a08488cacdc7e826699393adec82/partitioned-heat-conduction/solver-fenics/problem_setup.py#L26-L32)). For cases of practical relevance the geometry...

question

To make the API of the FEniCS adapter more stable, I think using a tool like mypy would be helpful. We can also automatize the type-checking process by introducing some...

student

The CI pipeline regularly breaks due to minor errors in code formatting and linting (workflows https://github.com/precice/fenics-adapter/blob/develop/.github/workflows/check-pep8.yml and https://github.com/precice/fenics-adapter/blob/develop/.github/workflows/check-links.yml). In https://github.com/precice/precice we use pre-commit hooks to force the user to take...

maintainability

**Please describe the problem you are trying to solve.** Simplify the implementation of `sendData/readData` in coupling schemes and reduce the number of necessary tests & options. **Describe the solution you...

maintainability
breaking change