Benjamin Rodenberg
Benjamin Rodenberg
The issue https://github.com/precice/tutorials/issues/374 basically originates from a bad integration of volume coupling into the overall code and a lack of testing. I decided to comment out the corresponding code to...
Our adapter only supports a single Neumann boundary condition on the whole domain (see [FEniCS tutorial book, p.85](https://fenicsproject.org/pub/tutorial/pdf/fenics-tutorial-vol1.pdf)). We add `g*ds` in the weak form to implement Neumann boundary conditions....
https://github.com/precice/fenics-adapter/blob/a2b5b5d0d6692fcd3e6e32ef618c4c2ec8cc5128/fenicsadapter/fenicsadapter.py#L62-L63 This function returns invalid values if evaluated somewhere outside of the coupling boundary. We should put an assertion or similar here.
Currently we initialize only a single read and a single write field: https://github.com/precice/fenics-adapter/blob/71da18293358c7cb0d19abf2017489aa7c207488/fenicsadapter/fenicsadapter.py#L153 For some applications we need more than one.
See https://github.com/precice/fenics-adapter/pull/59#issuecomment-635939898
#115 added the HT tutorials as a test. However, one thing is still missing to replace the current systemtests: We should also check the number of required coupling iterations to...
At FEniCS2021 @ReubenHill gave a talk on [using point data in Firedrake](https://fenics2021.com/talks/nixon-hill.html). This might be an alternative approach to our `CustomExpression` and interpolation based approach, where the `CustomExpression` just wraps...
When going through the repository I found another point that should potentially be discussed: Where/How do we want to maintain the citation information of the FEniCS adapter. Currently, we have...
Proposed by @fsimonis * [mypy](https://pypi.org/project/mypy/) * [type hints](https://docs.python.org/3/library/typing.html)