Benjamin Rodenberg
Benjamin Rodenberg
Like discussed in #800 converting some tags of the `coupling-scheme` into attributes would help us to avoid misconfiguration by design. This allows us to remove some (then obsolete) security checks....
**Please describe the problem you are trying to solve.** #1803 describes an assertion hit resulting from an invalid configuration. The corresponding invalid configuration and fix can be seen in https://github.com/precice/tutorials/pull/384....
The following compositional coupling scheme is currently allowed: ``` ... ... ... ``` I think one of the two parallel explicit schemes is not needed and we should raise an...
While working on https://github.com/precice/precice/pull/1526 we discovered that the test always was testing for wrong results. The problematic part is here: https://github.com/precice/precice/blob/b0b9593b37aa1ddb33a05797db6ce32180991cec/tests/serial/watch-integral/WatchIntegralScaleAndNoScale.cpp#L112-L115 Actually the following would be correct (see https://github.com/precice/precice/pull/1526#discussion_r1084139281): ```cpp...
**Describe your setup** I'm currently working on #1029. Here, I wanted to add [this assertion](https://github.com/BenjaminRodenberg/precice/blob/90415267f8a9be0daecf38edd3235801a57e17cd/src/time/Waveform.cpp#L19-L27) which ensures that no empty data is added. Here, I observed that some tests are...
**Describe your setup** preCICE Version: [0101034](https://github.com/precice/precice/commit/0101034b9f01af354afc9c4da147e77e20c5e58f), but should also be visible for `v2.5.0` **Describe the problem** The maximum simulation time of a coupled simulation is either defined via `max-time` or...
I just fixed the configuration of a test via https://github.com/precice/precice/commit/c088d0319ebe09bf13c28b8147a318cc06e308c8. The configuration looks wrong and preCICE should raise an error. Also related to #280.
Currently all packages of preCICE reference `Data::values()` to read or write data. Mapping, acceleration, communication and actions operate on the data in `Data::values()`. For time interpolation we recently introduced a...
**Describe your setup** preCICE Version: https://github.com/precice/precice/commit/8393841e62a78e87db1067543e2da4cc265e55d5 **Describe the problem** If the time window size is prescribed by setting `method="first-participant"` the first solver (F) can define a time window size that...
Subcycling and waveform iteration require changes to our existing acceleration schemes. This issue provides an overview and is meant for reference. Detailed discussions about individual schemes should go into dedicated...