BengtRydberg

Results 7 comments of BengtRydberg

> From a quick scan of this, this looks really well done. Thanks for adding it and making the pull request. I've made a few comments and suggestions. Let me...

> LGTM. Clean work, just two small comments inline. Regarding the failing test: it's being worked on, so we're waiting for it to be fixed before merging other PRs. ok.

> @BengtRydberg the tests are fixed in main now, could you merge main into your branch? I have merged main into the branch, but note that I had to add...

> @BengtRydberg Nice with the latest changes! I think it would be nice if you also added the appropriate identification keys in the yaml reader definitions, see for example what...

> LGTM. Very nice work! Just one thing: Can you add the reader to the list of supported readers in the documentation? See the `index.rst` file > > Also a...

> You aren't wrong about the coordinates being sorted by standard name, but I'm also not sure I like the inconsistency between these readers and others. Agree. I have changed...

> Could you merge main and resolve the merge conflicts? I think merging main will also take care of the SEVIRI test failures. Yes, I have merged main.