adding a reader for ATMS level1b data

[BengtRydberg]

This PR adds a reader for the Advanced Technology Microwave Sounder (ATMS) Level 1B data. The reason for this is that the nowcasting SAF intends to include a pipeline for processing ATMS within the PPS microwave package where satpy is used for reading of level1b data, and it seems that no existing reader for ATMS data is available within satpy.

• [ ] Closes #xxxx
• [x] Tests added
• [x] Fully documented
• [x] Add your name to AUTHORS.md if not there already

[codecov[bot]]

Codecov Report

Merging #2187 (093f622) into main (15be5c1) will increase coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2187      +/-   ##
==========================================
+ Coverage   94.14%   94.16%   +0.01%     
==========================================
  Files         294      296       +2     
  Lines       45183    45310     +127     
==========================================
+ Hits        42539    42666     +127     
  Misses       2644     2644              

Flag	Coverage Δ
behaviourtests	4.65% <0.00%> (-0.02%)	:arrow_down:
unittests	94.81% <100.00%> (+0.01%)	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
satpy/readers/atms_l1b_nc.py	100.00% <100.00%> (ø)
satpy/tests/reader_tests/test_atms_l1b_nc.py	100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[coveralls]

Coverage increased (+0.01%) to 94.762% when pulling 093f62228c231463537c1841c2823588afc5ccac on BengtRydberg:atms_reader into 15be5c1b0c00370d7e2a827c85da25250cad0c1f on pytroll:main.

[BengtRydberg]

From a quick scan of this, this looks really well done. Thanks for adding it and making the pull request. I've made a few comments and suggestions. Let me know what you think. What still needs to be done for this to be not a draft?

One reason this is a draft PR is that I wanted to include a data_identification_key (frequency_quadruple_sideband) in the yaml file that is currently being developed in https://github.com/pytroll/satpy/pull/2120

[djhoese]

One reason this is a draft PR is that I wanted to include a data_identification_key (frequency_quadruple_sideband) in the yaml file that is currently being developed in https://github.com/pytroll/satpy/pull/2120

Sounds good. Thanks for letting me know. I'm not sure I'm the right person to review something like that and it looks like Gerrit already got to it. Let me know if you need anything else from me until this PR is further along.

[adybbroe]

Oh, this is great @BengtRydberg I had adding ATMS reader on my to-do-list! :-) I will have a look at this shortly, and I am now trying to close the PR you refer to above!

[BengtRydberg]

LGTM. Clean work, just two small comments inline. Regarding the failing test: it's being worked on, so we're waiting for it to be fixed before merging other PRs.

ok.

[mraspaud]

@BengtRydberg the tests are fixed in main now, could you merge main into your branch?

[BengtRydberg]

@BengtRydberg the tests are fixed in main now, could you merge main into your branch?

I have merged main into the branch, but note that I had to add an rtol in assert_allclose test that is not mine, in order to not fail unit tests in CI. This test seems to test details from another package (skyfield). Maybe I should not have done this?

[mraspaud]

@BengtRydberg the tests are fixed in main now, could you merge main into your branch?

I have merged main into the branch, but note that I had to add an rtol in assert_allclose test that is not mine, in order to not fail unit tests in CI. This test seems to test details from another package (skyfield). Maybe I should not have done this?

that's fine.