Ben Wibking
Ben Wibking
**Describe the proposal** The HLLD solver should include the same low-dissipation pressure correction and carbuncle correction that are currently included in the HLLC solver. The relevant parts of the HLLC...
**Describe the bug** The HLLD solver sets the flux for the auxiliary internal energy variable to zero: https://github.com/quokka-astro/quokka/blob/edc1dbcf2e22ae47dc2d78aa9b0b6d0966671bb6/src/HLLD.hpp#L329 Within the Riemann solver, the auxiliary internal energy should be treated the...
**Describe the proposal** It appears necessary to ensure that the emf values are identical on edges shared between multiple boxes before computing the magnetic induction equation right-hand-side (rhs). This can...
**Describe the proposal** We can do raytracing on the CPU in order to compute the effects of direct radiation from sink particles, following the HARM^2 implementation: https://ui.adsabs.harvard.edu/abs/2017JCoPh.330..924R/abstract. **Describe alternatives you've...
### Description Initializes an isolated galaxy simulation with the AGORA initial conditions. ### Related issues N/A ### Checklist _Before this pull request can be reviewed, all of these tasks should...
**Describe the proposal** Coverity is a static analysis tool. Proprietary, but free for open source projects. It can only be run a limited number of times per week, but we...
**Describe the proposal** For many applications, the radiation emissivity is not a Planck function (i.e., non-LTE). Often, this also requires solving the level populations of atomic or molecular states to...
**Describe the proposal** We should document the meaning (and units, when relevant) of the `EOS_Traits`, `Physics_Traits`, and `Rad_Traits` member variables. **Additional context** This would help avoid bugs like https://github.com/quokka-astro/quokka/issues/493.
Plan to add basic particle support: - Follow implementation used in PeleC (https://github.com/AMReX-Combustion/PeleC/blob/development/Source/Particle.cpp) - This requires both *virtual particles* and *ghost particles* to handle AMR with subcycling-in-time "Basic particle support"...
**Describe the proposal** The code should refuse to run if the CFL number is too high for linear stability. This is the case for ~0.3 is 3D and 0.5 in...