Ben Wibking

update shock-cloud problem

9

This updates the shock-cloud problem to use a new setup that: - tracks the cloud center-of-mass frame - refines so that the cooling length $l_{\text{cool}} = c_s t_{\text{cool}}$ is resolved...

**Describe the proposal** Add a public invite link to the "Quokka users' group" Slack workspace (quokkausersgroup.slack.com) to README.md and to the Sphinx documentation: **Describe alternatives you've considered** N/A **Additional context**...

amrex::Abort does not unconditionally abort on GPU

4

**Describe the bug** We have been relying on `amrex::Abort` to unconditionally abort the code when called from GPU code. However, this only works when compiled in debug mode (or with...

in rare cases, NSCBC outflow produces unphysically high velocities

2

**Describe the bug** In very rare circumstances, the NSCBC outflow boundary conditions can produce states in isolated cells at the boundary that have unphysically high velocities. An ad hoc (but...

### Description This adds the `DiagConditional` diagnostic from [PelePhysics](https://amrex-combustion.github.io/PeleLMeX/manual/html/LMeXControls.html#run-time-diagnostics). It computes the volume average, volume integral, or sum of a variable. This operation is optionally filtered by and/or conditioned on...

### Description This sets up ARM64 CI testing on CircleCI. In the near future, we will disable the ARM64 CI testing currently on Oracle Cloud, which is harder to maintain...

quokka::EOS code linting

8

### Description This fixes some clang-tidy and CodeQL warnings for EOS.hpp. ### Related issues https://github.com/quokka-astro/quokka/security/code-scanning/2609 ### Checklist _Before this pull request can be reviewed, all of these tasks should be...

refuse to build when Cray compiler is detected for CPU-only builds

2

**Describe the proposal** We refuse to build when the Cray C/C++ Compiler (cce) is detected *and* we are doing a CPU-only build. It miscompiles the code and produces wrong output....

set `-mllvm -amdgpu-function-calls=true` for HIP builds

3

**Describe the proposal** We should automatically add `-mllvm -amdgpu-function-calls=true` to the compiler flags when `-DAMREX_GPU_BACKEND=HIP` (AMD GPUs). This works around compiler bugs for large GPU kernels (e.g., chemistry networks). **Describe...

**Describe the proposal** Different C++ standard library implementations implement `std::min`, `std::max` and `std::clamp` in incompatible ways. We can avoid this by implementing these functions ourselves, e.g. by copying the implementation...