Ben Wibking
Ben Wibking
The cooling tables in the repository are inconsistent with the convention expected by AthenaPK (https://github.com/parthenon-hpc-lab/athenapk/pull/97). https://github.com/parthenon-hpc-lab/athenapk/tree/main/inputs/cooling_tables For temperatures about $10^{5.5}$ K where CIE is valid, this causes a 10-20% discrepancy...
New version of https://github.com/parthenon-hpc-lab/athenapk/pull/57.
New version of https://github.com/parthenon-hpc-lab/athenapk/pull/58. (Renamed the branch and didn't realize the PR would be closed automatically.)
Two things are not clear to me: 1. Does first-order flux correction (as implemented here) drop to first order fluxes for each stage separately? (i.e., does it still do higher-order...
The Parthenon reflecting boundary conditions do not work correctly in AthenaPK, because AthenaPK allocates variables in a different way from other Parthenon codes. I will add custom boundary conditions for...
For various things, it would be useful to reconstruct a different set of variables other than the primitive variables. For example, we might want to reconstruct (density, velocity, temperature) instead,...
This will be useful for many galaxy cluster applications. There is * HLLC-LM: https://ui.adsabs.harvard.edu/abs/2020JCoPh.42309762F/abstract * low-dissipation HLLD: https://ui.adsabs.harvard.edu/abs/2021arXiv210804991M/abstract HLLC-LM is not stable for very low-amplitude linear waves, but it works...
It looks like the gravitational potential is hard-coded to be only a function of radius: https://github.com/parthenon-hpc-lab/athenapk/blob/ca22b732bf8ce1bd883668830b316cc851f786b4/src/hydro/srcterms/gravitational_field.hpp#L52 In general, it should be a function of all of the coordinates. (For my...
Enable reading plotfiles with pyAMReX. Closes https://github.com/AMReX-Codes/pyamrex/issues/317. *TODO:* add tests
**Describe the bug** Installing ADIOS2 with `pipx install adios2` on macOS 14.4 fails. **To Reproduce** A minimal reproducible example is preferred. Or Steps to reproduce the behavior: 1. Run `pipx...