Ben
Ben
> could you add a `rules.mk` file in directory `keyboards/keycapsss/kimiko` defining default folder to either rev1 or rev2 sub directory? (am assuming rev2 would be the desired default) > `DEFAULT_FOLDER...
I would delete the `oriaj3` keymap, because it's not compatible with the new changes. Is that fine?
@dunk2k thanks for clarifying about the rev1 keymap error. Can you help with this problem? https://github.com/qmk/qmk_firmware/pull/21719#discussion_r1323267304
@dunk2k yes we can do that. Can you help with the `#ifdef` code?
@dunk2k thank for the quick help. Rev1 and Rev2 default keycaps compile. The if code in the rule.mk does not work correct. Get `keycapsss/kimiko/rev2: SPLIT_KEYBOARD in rules.mk is overwriting split.enabled...
Pushed your suggested changes. Also checked the `ifeq ($(strip $(KEYBOARD))` code on other keyboards and it's the same. Strange Lint successful. Build is in progress. Wow what a PR. 🥵
All default keymaps compile without an error and lint is also successful. As dunk2k mentioned, "The oriaj3 keymap build failure(s) will be corrected in a follow-up PR based to develop...
The default folder is already set. @drashna https://github.com/BenRoe/qmk_firmware/blob/72e48e277bb960636400baa37c36e7371ad869e3/keyboards/keycapsss/kimiko/rules.mk#L1
If possible please merge this PR.
Thank you @lesshonor for your contribution.