Luca
Luca
Update on this: it seems that since Android 11 package visibility has been reduced. https://developer.android.com/training/package-visibility https://medium.com/androiddevelopers/package-visibility-in-android-11-cc857f221cd9 I opened a PR to fix this, see https://github.com/digitalbitbox/bitbox-wallet-app/pull/1793
PR merged, closing
@benma during our last eng sync you proposed to find a solution to avoid having currency/coins string around in the code, like here: https://github.com/Beerosagos/bitbox-wallet-app/blob/formatting-refactor/backend/coins/coin/conversions.go#L14 I made a check and I...
@benma after our talk about float precision I decided to make some tests and verify how much we can relay on `float64` to correctly handle coins and fiats, since it...
New update pushed, slightly different from what requested, but hope it is good
Nice! Only thing I noticed is that there is still a generic error when the user aborts while restoring from backup. I would suggest adding a check on the error...
> > @Beerosagos that means ACK? smile > > (the Restore thing is a separate issue imo) in that case ACK :)
Pushed an update, but just found a bug. Converting to draft until it is fixed
Bug should be fixed: it was failing to retrieve erc20 coins in `getConvertToPlainFiatHandler`. PR Re-opened and ready for a new round of review :+1: