Fabien Salathe

Update bundle page to reflect best practices #15881

3

Fix documentation to reflect best practices page: https://symfony.com/doc/5.4/bundles/best_practices.html#directory-structure See: #15881

Directory structure consistency

2

Some UX bundles are using the `src/` folder to have the php logic (eg. https://github.com/symfony/ux/tree/2.x/src/Autocomplete) and some are not (eg. https://github.com/symfony/ux/tree/2.x/src/Chartjs). As discussed in https://github.com/symfony/symfony-docs/issues/15881 it would be great to...

Add a "getConfig" method to make it easier to extends

15

Currently it's pretty difficult to run PHP code sniffer programmatically, often it's about changing the configuration but unfortunately there is no dependency injection, this PR makes it a bit easier...

Add constants for exit return codes

2

Inspired by https://github.com/symfony/symfony/blob/6.2/src/Symfony/Component/Console/Command/Command.php#L37-L40, to make the code more readable and to avoid miss-using exit codes.

Use DTOs to map requests (using MapRequestPayload & MapQueryString)

5

The demo is a good place to show the best practices. Now that we have the new attributes to map requests to DTOs (`MapRequestPayload` & `MapQueryString`) I think it would...

Use `#[MapRequestPayload]` for admin blog controller

3

Fix #1434 Unfortunately there is no Rest endpoints in the demo, I think it would have been more interesting to use it then.

Hey, This repository is unmaintained since years and not compatible with recent PHP versions, I think it would be good to archive it. And feel free to mention us (https://github.com/ProtonMail/bitcoin-php),...

`TestCase` should not extend `Assert`

2

`TestCase` is currently 2276 lines long and contains 129 functions, we can argue that this class concentrates too much responsibilities and is a god class. Unfortunately this class extends `Assert`...

Split this package is multiple sub-packages

1

**Is your feature request related to a problem? Please describe.** Currently this library can be required using `azjezz/psl`, the "issue" is that it comes with everything. I think it would...

Inject the Config in the Runner constructor

1

Inject the configuration object in the constructor instead of creating the instance without having the ability to change it. Currently it's not possible to change the configuration because it's using...