Olivier Mélois
Olivier Mélois
> I ask because after running the rules to generate some def unapply for our case classes, two things happen To be clear : I don't quite remember how scalafix...
For the sake of the discussion, I'm gonna completely ignore that you're trying to do both, because it creates noise in the discussion. We'll focus exclusively on the linting aspect....
@daddykotex the internal ones can be left alone, provided they are adequately marked as private or package private. Leave me deal with the ones that extend `Document` and the ones...
Don't have much thoughts about it besides "let's fix it I guess ?"
well let's change it then.
Right, this has nothing to do with whether the http method is `HEAD`. The reason it doesn't work is this filter : https://github.com/disneystreaming/smithy4s/blob/f3f28fc78e4ff41c2aff5517cbea183c31296fbc/modules/core/src/smithy4s/http/HttpResponse.scala#L119 Now that being said, I'm not sure...
@kubukoz got it right : this is simply not something I'm willing to commit to providing a solution for, because the fact that we're letting users come with their own...
@LukaJCB we've not really considered it. Truth be told, teams in our organisation are still mostly on Scala 2, so there's a little bit of an ignorance bias there, but...
> Fewer changes to codegen? yup
> I like the idea, but that will require protocol-specific handling in the codegen I think I think I'm fine with it because it's not adding any protocol specific **logic**...