Olivier Mélois

Results 260 comments of Olivier Mélois

> Maybe implementing both would work as expected. That is indeed what I think we should do.

I think you are correct. `uniqueItems` should be treated as a validation constraint as opposed to a meta-hint dictating the generated type.

No thoughts, except maybe why do you want to store the shapes at all, in the metadata ? I think the assumption that everything was generated in a model is...

Good question. TBH, the fact that it matched your expectations previously was kinda accidental. However it may make sense from a least-surprise point of view. It may be worth treating...

Please refrain from force-pushing once you've opened a PR. It prevents the review of the latest changes, and also makes it extremely annoying if someone was branching out from your...

> I thought you were OK with it so long as the change is in draft state, not PR It's not about whether it's a draft or not. I switch...

It's undocumented, but in theory using this trait should work : https://github.com/disneystreaming/alloy/#alloyurlformname

yeah, let's add those to the [reserved words list](https://github.com/disneystreaming/smithy4s/pull/1231/commits/56a3cd09688f6c9cfd550ee03dcf504573e3fef1#diff-9440513678bbc49279027eba8b9f8173ca4cb5a7d06476be3bf20ea95ab052b3), like we did for methods coming `java.lang.Object`