Olivier Mélois
Olivier Mélois
Don't forget to sign the CLA
Yeah I'm happy to change the modelling of HttpUri in 0.19. As a matter of fact we already have, to make the host optional and better cater to JS
Hey @denisrosca , thanks for looking into this. However : validated newtypes should not be rendered by default, for the simple reason that it'd break a lot of user code...
If anything, this is yet another argument for rendering dynamic bindings instead of static ones. As much as I hate to say it, the arguments in favour of dynamic bindings...
> Not sure what you mean here - I was thinking of using the smithy4sGenerated metadata, which does get inspected by downstream codegen runs. Well, thing is in order to...
My bad, haha
> What do you think about making this setting a full-blown generator argument instead of passing it via the generated metadata file? You make a good point, it'd be silly...
That's sensible, actually !
It's getting close 👍 just wanted to say that your efforts are much appreciated, and apologise for how long it takes me to review
I don't think collection tags should be captured by Dynamic, as collection tags are performance related, not behaviour related. I think defaulting to lists is likely wrong, and defaulting to...