BSchelpe

Results 17 comments of BSchelpe

> +1 for an inclusive policy on authorship assuming the journal permits it. I'm afraid I'm not sure we can change the author list at this stage of the submission....

I'm running Windows on quite an old ThinkPad and this made a big difference to me too: Without database: 94s 1st run with database: 50s 2nd run with database: 10s....

Thanks! Yes when I'm done I think the last remaining piece of work on this will be finished. If you could assign me that would be great. I also think...

> The docs build failed because I replaced the values of `PauliBasis` enum with uppercase "X"/"Y"/"Z" and the deserialization of saved detector database will raise exception now. When I tested...

> > Bumping the database version is the right thing to do, thanks! It means that if you're using the default database it will automatically rebuild next time you run...

> > At least this was the behaviour last time I touched the code, I don't know whether @Zhaoyilunnn might have made any changes to this part of the behaviour...

> In my opinion, the most pythonic way of handling versions is to use [`semver`](https://pypi.org/project/semver/). From the package documentation: > > > The module follows the `MAJOR.MINOR.PATCH` style: > >...

> > That makes sense to me. I'll add your guidance on what constitutes a major/minor change to the doc string. Given that does starting the version at 0.1 make...

@nelimee this is ready for final review, when you have time :)