tqec icon indicating copy to clipboard operation
tqec copied to clipboard

Address JOSS reviewer feedback

Open purva-thakre opened this issue 1 month ago • 6 comments

Following information is added to the JOSS paper:

describe how tqec compares to other commonly used QEC packages

purva-thakre avatar Nov 19 '25 18:11 purva-thakre

Code Coverage

Package Line Rate Complexity Health
src.tqec 100% 0
src.tqec.circuit 96% 0
src.tqec.circuit.schedule 99% 0
src.tqec.compile 93% 0
src.tqec.compile.blocks 94% 0
src.tqec.compile.blocks.layers 95% 0
src.tqec.compile.blocks.layers.atomic 97% 0
src.tqec.compile.blocks.layers.composed 99% 0
src.tqec.compile.detectors 89% 0
src.tqec.compile.observables 97% 0
src.tqec.compile.specs 92% 0
src.tqec.compile.specs.library 97% 0
src.tqec.compile.specs.library.generators 97% 0
src.tqec.compile.tree 81% 0
src.tqec.compile.tree.annotators 83% 0
src.tqec.computation 96% 0
src.tqec.gallery 100% 0
src.tqec.interop 90% 0
src.tqec.interop.collada 94% 0
src.tqec.interop.pyzx 85% 0
src.tqec.interop.pyzx.synthesis 91% 0
src.tqec.plaquette 90% 0
src.tqec.plaquette.compilation 100% 0
src.tqec.plaquette.compilation.passes 95% 0
src.tqec.plaquette.compilation.passes.transformer 99% 0
src.tqec.plaquette.rpng 94% 0
src.tqec.plaquette.rpng.translators 97% 0
src.tqec.post_processing 82% 0
src.tqec.post_processing.utils 96% 0
src.tqec.templates 94% 0
src.tqec.utils 96% 0
Summary 94% (7450 / 7944) 0

github-actions[bot] avatar Nov 19 '25 18:11 github-actions[bot]

A preview of is uploaded and can be seen here:

✨ https://tqec.github.io/tqec/pull/780/ ✨

Changes may take a few minutes to propagate.

github-actions[bot] avatar Nov 19 '25 18:11 github-actions[bot]

Minor issue I just ran into: Loom does not have a DOI for citation purposes. https://loom-docs.entropicalabs.com/

Will have to manually generate a bib entry.

purva-thakre avatar Nov 19 '25 18:11 purva-thakre

I'd be happy to help draft a comparison between tqec and other relevant packages, if it has not been done yet.

Also, would it be possible to update the list of authors to the current contributors in this paper revision? I, for one, was late to the party due to a policy at work and missed the submission of the JOSS paper. I am and do intend to continue making some nontrivial contributions to tqec, such as the correlation surface finding algorithm.

HaoTy avatar Nov 25 '25 08:11 HaoTy

+1 for an inclusive policy on authorship assuming the journal permits it.

On Tue, Nov 25, 2025, 12:21 AM Tianyi Hao @.***> wrote:

HaoTy left a comment (tqec/tqec#780) https://github.com/tqec/tqec/pull/780#issuecomment-3574298504

I'd be happy to help draft a comparison between tqec and other relevant packages, if it has not been done yet.

Also, would it be possible to update the list of authors to the current contributors in this paper revision? I, for one, was late to the party due to a policy at work and missed the submission of the JOSS paper. I am and do intend to continue making some nontrivial contributions to tqec, such as the correlation surface finding algorithm.

— Reply to this email directly, view it on GitHub https://github.com/tqec/tqec/pull/780#issuecomment-3574298504, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKAXTCFTCFNRIKM2IP4ZWL36QGPPAVCNFSM6AAAAACMTKDFXSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTKNZUGI4TQNJQGQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

afowler avatar Nov 25 '25 08:11 afowler

I'd be happy to help draft a comparison between tqec and other relevant packages, if it has not been done yet.

Thanks for the offer. This is already done as that's the intention of the PR. I just need sometime to push it to this PR. I have been busy with other personal things.

purva-thakre avatar Nov 26 '25 10:11 purva-thakre

+1 for an inclusive policy on authorship assuming the journal permits it.

I'm afraid I'm not sure we can change the author list at this stage of the submission. This isn't a revision of the paper, but a requested change by a reviewer for the original submission. One reviewer has already completed their review. I think at this stage we can only make changes requested by the remaining reviewers for this submission. However, we can certainly increase the author list for future paper submissions!

BSchelpe avatar Dec 01 '25 21:12 BSchelpe

Please do reach out to the journal and confirm their policy on this. Best, Austin.

On Tue, Dec 2, 2025 at 5:39 AM BSchelpe @.***> wrote:

BSchelpe left a comment (tqec/tqec#780) https://github.com/tqec/tqec/pull/780#issuecomment-3599037539

+1 for an inclusive policy on authorship assuming the journal permits it.

I'm afraid I'm not sure we can change the author list at this stage of the submission. This isn't a revision of the paper, but a requested change by a reviewer for the original submission. One reviewer has already completed their review. I think at this stage we can only make changes requested by the remaining reviewers for this submission. However, we can certainly increase the author list for future paper submissions!

— Reply to this email directly, view it on GitHub https://github.com/tqec/tqec/pull/780#issuecomment-3599037539, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKAXTGTSD4UT5QBBUQHIH337SYR5AVCNFSM6AAAAACMTKDFXSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTKOJZGAZTONJTHE . You are receiving this because you commented.Message ID: @.***>

afowler avatar Dec 01 '25 23:12 afowler