Benedikt S. Vogler

Results 53 comments of Benedikt S. Vogler

Would be great to have a QuickLook preview as well. Unless there is an overlap with this ticket it should get into its own story, I guess.

@nwydmuch You probably did not saw my edit. I have sdl2 installed.

You were right. I uninstalled the brew one. `make` says that it found the one in `/Library/Frameworks/SDL.framework` However I am still getting the same error. :(

I can confirm every point but this one: There is not such command as `sdl2-config` on my system. After all it's just a framework in the frameworks folder.

I found a solution. The problem is that `/Library/Frameworks/SDL.framework` version 1 is being used even if cmake says it found the installed SDL2 version. Can this be caused because "sdl.h"...

Clipping values to avoid overflow comes at some costs. See [this SO answer](https://stackoverflow.com/questions/29611185/avoid-overflow-when-adding-numpy-arrays). So this is design decision to optimize for speed/memory or convenience. As this is a python library...

the unsuspecting user won't read the documentation first.

I am still observing the same behavior. https://github.com/keras-team/governance/pull/10 is merged. Is someone looking into this? For reference: The code mazatov cited is found here https://github.com/keras-team/keras-preprocessing/blob/0494094a3ba341a67fdb9960e326fe6b9f582708/keras_preprocessing/image/affine_transformations.py#L159-L180 I am not familiar with...

A fix should probably also address issue #170.

I put a fix on [a fork](https://github.com/BSVogler/keras-preprocessing). Still needs to be tested before I add a pull request. There is also some clipping to the min and max values contained...