BFedder

Results 23 comments of BFedder

I'll sum up what has been discussed so far here to facilitate the discussion. Current behaviour as of 2.2.0 is that mass densities are returned in units of g/cm^3, charge...

I had a quick look, is there any reason why the copy method couldn't just take the output from `mda.auxiliary.base.get_description` to create and return a new instance of the AuxReader?...

I have now adapted the tests for the trajectory-independent functionality. Next step will be the association of energy data to trajectory frames.

Hi @hmacdope @orbeckst @IAlibay @fiona-naughton, could I ask for your thoughts on this now? :) I believe it is ready

Thanks for your review IAlibay! I will upload the first bit of reworking in a bit, and think about the other points you raised over the weekend.

>Move attaching of data from coordinates/base to auxreaders themselves. add_auxiliary shouldn’t need to know which file format is actually attached. self.add_auxiliary(AuxReader, ...) — use callback pattern in the classes. This...

Ahhh, I only ran the test in MDAnalysisTests/auxiliary, not the entire testsuite before committing... And here we are. I'll fix this tomorrow

The API is now reworked as discussed, and most of your comments should be addressed now as well. Could I ask you to have another look please @hmacdope @orbeckst @IAlibay...

Thanks, @orbeckst! I don't think it would ever make sense to provide `auxdata=None`, I cannot think of a use case. So I think changing the order in 3.0 is a...

This new implementation now checks what units the data are in on creation of an EDRReader instance. If the units are already defined in MDAnalysis.units (pressure isn't, for example), then...