BFedder

Results 23 comments of BFedder

Unit handling is now part of this PR. `EDRReader` holds a `unit_dict` that stores the units of each term as read from `pyedr`. During initialisation, the reader attempts to convert...

This should have addressed your reviews now, @orbeckst @hmacdope - thanks! However, the mypy check is failing now and I don't understand why. Mamba raises the runtime error "RuntimeError: Found...

Thank you! That's addressed now as well

The remaining PEP8 complaints are URLs, a table, and the import done to match what's already present.

Thanks for the reviews, this should address them @IAlibay @orbeckst

I'm not sure what to do about the Cirrus CI failing, the error message seems like it's not due to any change I made... Could I ask for advice, please?

I have now used a defaultdict in `calc_representative`, moved the comments in test_edr into class docstrings, and opened issue #3830 as a place to discuss the future of `calc_representative` with...

This latest batch of reviews is now also addressed, and the checks pass. I believe the EDRReader is now ready to be merged, then :partying_face: Thanks everyone for your mentorship,...

This ended up taking a bit longer after all, sorry! But #3749 is now merged, so all good on our end.

I think it makes sense to have two different places to store additional information, one where stuff needed for some functionality is automatically added, and one where the user controls...