Martin Adámek

Results 768 comments of Martin Adámek

Well, since your snapshot file was correctly updated, I don't see how that could happen. edit: hmm or is it quite the opposite? if so, I'd welcome a repro for...

Good point. Maybe we could even have an object in the first parameter, it would have both table name and schema name as properties, and a `quoted` (or `quotedName`?) property,...

> As for the other property, should we choose table.fullyQualifiedQuotedName instead of table.quotedName ? That's way too huge, I would be fine with `table.quoted`, clear and concise, `quotedName` is fine...

Hmm, that's weird, I would very much like to keep the type safety we have now, it would be a downgrade to lose that. Did you try the [same condition](https://github.com/mikro-orm/mikro-orm/blob/833a6403ca393c341fca8e6207652d063fdb0677/packages/core/src/decorators/Indexed.ts#L33)...

It seems to work fine for me with that approach: ```ts expression?: string | (T extends EntityClass ? IndexCallback : IndexCallback); ``` It won't allow to pass the type explicitly,...

The inference in those decorators is rather new addition, and its incompatible with the explicitly provided type argument, IIRC I left the check decorator as is since it felt breaking...

This is a knex bug technically, we won't get around this unless we reimplement the schema diffing completely in the ORM (which I would like to do for v7, but...

Feel free to explore that. I am personally not interested in spending more time on hacking knex, I will rather spend the time on getting rid of it. But I...

This needs to work like with the JS version, so based on `Actor.init` call from the SDK. And that itself is where we do the detection, not in crawlee.

We also log the message on the basic crawler level (to the debug level, since it's executed quite often, every 10 seconds iirc). What is ignored is the API call...