Martin Adámek

icon indicating a website link https://mikro-orm.io icon indicating an email [email protected]

icon company @mikro-orm icon location Prague icon location Long time php/nette/doctrine developer, now shifted to javascript world (node/typescript/angular). Building MikroORM in my free time.

Results 768 comments of Martin Adámek

Injecting dependency into `useFactory` results in error.

I did a quick and dirty hotfix by awaiting the `useFactory`, which should fix the try/catch block. Keeping this open till we find a proper way. Available in v5.1.6

Injecting dependency into `useFactory` results in error.

Closing as resolved via #166, will be part of v5.2.4

refactor(cli): made the CLI explicitly pass the config path from the arg, or else infer it once

> If the config path is automatically inferred from a CLI argument during MikroORM.init(), a deprecation warning is logged. I am still not sure about this one, can you remind...

refactor(cli): made the CLI explicitly pass the config path from the arg, or else infer it once

Ok, thanks for the write-up, agreed with the points you made. > remove empty init altogether I am not so sure about this one, mainly because of the use case...

refactor(cli): made the CLI explicitly pass the config path from the arg, or else infer it once

please don't rebase once you get a review, i have no idea what is changing now

refactor(cli): made the CLI explicitly pass the config path from the arg, or else infer it once

Btw I wanted to ship v6.4 later this week unless you have some plans to PR something worth including in a feature release?

refactor(cli): made the CLI explicitly pass the config path from the arg, or else infer it once

> Considering it's not a breaking change, and the modifications will be to "internal" classes, I think it's ok to have it even in a minor release like 6.4.1 or...

refactor(cli): made the CLI explicitly pass the config path from the arg, or else infer it once

> ok, made deprecated be outputted by default by the default logger... by changing the default of "debugMode" from "false" to "['deprecated']". An explicit "false" would still behave the same...

refactor(cli): made the CLI explicitly pass the config path from the arg, or else infer it once

Indeed, I said we need a way to opt-out. I just don't think we should mix this with the existing mechanism, as deprecations are important and they could be easily...

refactor(cli): made the CLI explicitly pass the config path from the arg, or else infer it once

One last thing is the docs for the `ignoreDeprecations` option, not sure where it fits better, either https://mikro-orm.io/docs/logging or https://mikro-orm.io/docs/configuration (or both)