Martin Adámek comments

Results 768 comments of


                                            Martin Adámek

EntityManager injection broken >5.1.2 with custom factory using PinoLogger and built via ncc

> For example, if I make the whole MongoService in my reproduction have a scope but skip it in MikroOrmModule.forRootAsync, then I still get ValidationError when using the repository. As...

feat(schema): filter tables before fetching table details

Looks like there is still one line that is no longer covered by tests, not a big deal in terms of coverage, I just wonder if it's needed or what...

feat(schema): filter tables before fetching table details

That method was quite overcomplicated, we don't need 4 return statements and nested conditions at all, refactored here to get around this without more tests. 04321e06ce083ec129432cc3436846737382b006

docs: Update apify_platform.mdx

i am not completely opposed by adding the link there, but it feels like you missed the fact that you don't need any tooling to set env var. also you...

docs: Update apify_platform.mdx

closing as stale

feat(core): add `first` and `last` methods to `Collection` class

fyi i will most likely remove the whole `ArrayCollection` (and inline it to the `Collection`) since that abstraction makes very little sense and only makes things harder to write/test. but...

feat(core): add `first` and `last` methods to `Collection` class

@rubiin do you plan to finish this?

feat(core): add `first` and `last` methods to `Collection` class

Closing as stale

Using htmlparser2 results in mutilated doctype

It's a shame there are bugs in the v1 release and nobody seems to even try to respond to them, yet alone try to fix them. This radio silence from...

Foreign key constraints renamed in snapshot without generating migration

We are not diffing the FK names at all, that's why this doesn't generate any queries. I am not sure if it makes sense to deal with FK names, right...