Yang, Bo

Results 342 comments of Yang, Bo

Scaladoc sometimes does not create link to `type` aliase

@jumpkick Could you review this PR, please?

Ideally `+=` should be used to ensure the exit codes of all substitutions are not discarded. ``` set -e echo_flags+=("$(echo Failed to produce a flag >&2; false)") echo_flags+=("$(true)") echo_flags+=(I am...

Hi @fredemmott, Previously the first-party dependency was using git submodules, which is easier to update. You changed it to CMake settings last year, which is harder and slower to update....

> unless pointed at a tag, they're unreliable and non-reproducible after a while: GitHub stops serving requests for submodules by sha after a variable amount of time/number of commits/not sure...

> It's also important to note: auto-updating is entirely independent of submodules vs externalproject_add. They're formulaic, and it would be relatively straightforward to change them to be more formulaic. Do...

It's a ton of helpful information about the previous made decisions! #Thank you! @fredemmott

Sounds reasonable! For comparison, `fbthrift` is using the bot to update submodules, e.g. https://github.com/facebook/fbthrift/commit/3fe8c7c50f4ad4829f0bebbe703a07ce53298a69