Yang, Bo

Results 342 comments of Yang, Bo

Interesting because we did not give any special treatment between empty and non-empty string attributes. https://scalafiddle.io/sf/YVOjunl/0

Fortunately this inconsistency is not found on boolean attributes: https://scalafiddle.io/sf/YVOjunl/2

Interesting, I suspect there is an underlying bug in https://github.com/scalamacros/paradise

Seems like upickle generates something not supported by [MonadicFactory](https://github.com/ThoughtWorksInc/each/blob/3.0.x/core/src/main/scala/com/thoughtworks/sde/core/MonadicFactory.scala)

Workaround: use upickle in normal methods like what I did in https://github.com/ThoughtWorksInc/todo/blob/master/js/src/main/scala/com/thoughtworks/todo/Main.scala

You can use `xxx.toBindingSeq` with the help of [this library](https://github.com/ThoughtWorksInc/bindable.scala)

This issue is good for first-time contributors. You can add some translation rules in [dom.scala](https://github.com/ThoughtWorksInc/Binding.scala/blob/11.0.x/dom/src/main/scala/com/thoughtworks/binding/dom.scala) and [XmlExtractor.scala](https://github.com/ThoughtWorksInc/Binding.scala/blob/11.0.x/XmlExtractor/src/main/scala/com/thoughtworks/binding/XmlExtractor.scala) , in order to convert a `scala.xml.PCData` to a `org.scalajs.dom.raw.CDATASection`.

I meant `Vector.patch` method, which are called whenever a @`BindingSeq` changes https://github.com/ThoughtWorksInc/Binding.scala/blob/6ff5e1e8d79d44916c2e79b5642f1296ed2856f4/Binding/src/main/scala/com/thoughtworks/binding/Binding.scala#L485 `Vector.patch` is O(n) in current version (2.10.6 or 2.11.8) of Scala.

@kantianethics I agree. I changed the title of this issue in order to fit solutions other than finger tree.