Jeremy Privett
Jeremy Privett
The directory structure seems a little inconsistent. - Root level - Technical directories are mixed with the feature directories (eg. components, utils mixed with home, profile, issues). # Acceptance -...
Currently navigating to a page that doesn't have any data will try loading eg. a user, and display a graphql error. # Acceptance - Navigating to a page that doesn't...
Remove the work that has been done on this showcase from the repo. Likely just exists in an integration branch.
# Acceptance As either a write up in Google Docs or as comments on this issue, please provide us with: - Any bugs you find clicking through the app -...
We should create the observables outside of the components/hooks. Though it can be tempting to create the observables in components like in `RepoPage.data.tsx` or `UserProvider.tsx`, or in hooks like `useSetToken()`...
A files most import export, whether that is a component, a class or a function, should probably be at the top of the file as soon as you open it,...
Currently label selector doesn't support multiple selections. # Acceptance - Add multiple selection functionality to the label selector
- Pull requests use single store that also manages filters, however issues have 2 separate stores. - Component's state seems to be designed in a way that doesn't support easy...
Profile directory can probably be split into `user` and `org`. `ProfileResolver` uses `ActivatedRouteSnapshot.url` to resolve params, but they could use `ActivatedRouteSnapshot.paramMap.get('owner')` to avoid conditional logic.