Sam Atkins
Sam Atkins
I keep forgetting about this. 😅 (And possibly avoiding it...)
Looks fine to me. Going from a path to another path in the same directory is pretty awkward though, maybe that could be a `.sibling("blah")` method? I don't know how...
> I'm not sure why the crash is referring to this line: [`fbde901`/Userland/Utilities/mktemp.cpp#L80C63-L80C63](https://github.com/SerenityOS/serenity/blob/fbde901614368dcf03d4a8eee800d8b89131465f/Userland/Utilities/mktemp.cpp#L80C63-L80C63) > > When I run `mktemp -p .`, `file_template` should be empty at this point in execution...
An alternative idea I've been toying with, (but haven't worked on,) is to move the property definitions into a JSON file, and use that in the GML compiler, widget initialization,...
Unfortunately I can't give you permission to edit that issue. GitHub either lets you just edit your own, or EVERYTHING. I've no idea how up to date the other issue...
Fixed the conflict, from me being a big silly and making the same change in two PRs without realising. :laughing:
> also htmlscriptelement is a bit too strict: > > HTMLScriptElement: Refusing to run script because the type '04f963fb78cc8af4e291c809-text/javascript' is not recognized. > > Perhaps it should just look for/match...
Looking at the DOM inspector in Firefox, `` in the source is becoming `` in the actual DOM. So yeah, something is modifying it.
This is a bit of a tangent, but while poking around, I noticed that Serenity's patch implementation is also written by you. 😆 Is there much of a difference between...
CI failure is legitimate, I need to put replacement implementations in for `clearenv()` and `secure_getenv()` on MacOS.